[PATCH] D38425: [clangd] Document highlights for clangd

Ilya Biryukov via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Sep 29 15:14:59 PDT 2017


ilya-biryukov added a comment.

Thanks for the patch, I'll take a closer look a bit later.
But just wanted to post one very important comment right away.



================
Comment at: clangd/ClangdUnit.h:268
+std::vector<DocumentHighlight> findDocumentHighlights(ParsedAST &AST, Position Pos,
+                                      clangd::Logger &Logger);
+                                      
----------------
Please `clang-format` the code on every submission!


https://reviews.llvm.org/D38425





More information about the cfe-commits mailing list