[PATCH] D31140: [LLVMbugs] [Bug 18710] Only generate .ARM.exidx and .ARM.extab when needed in EHABI
Christian Bruel via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Fri Sep 29 07:14:08 PDT 2017
chrib updated this revision to Diff 117139.
chrib added a comment.
Hello,
I realized that testing CCCisCXX for IsUnwindTablesDefault was not really good and useless here, because we cannot treat C as C++ mode. In fact only the file type matters, as seen in the tests.
So I'd like to amend my previous proposal to
- Add the InputType parameter to IsUnwindTablesDefault and use in the new function ARMNeedUnwindTable
- Fix tests thinko (wrong triplet)
- Rebase
sorry for the respin, thanks !
https://reviews.llvm.org/D31140
Files:
include/clang/Driver/ToolChain.h
lib/Driver/ToolChain.cpp
lib/Driver/ToolChains/Arch/ARM.cpp
lib/Driver/ToolChains/Arch/ARM.h
lib/Driver/ToolChains/BareMetal.cpp
lib/Driver/ToolChains/BareMetal.h
lib/Driver/ToolChains/Clang.cpp
lib/Driver/ToolChains/CrossWindows.cpp
lib/Driver/ToolChains/CrossWindows.h
lib/Driver/ToolChains/Darwin.cpp
lib/Driver/ToolChains/Darwin.h
lib/Driver/ToolChains/Fuchsia.h
lib/Driver/ToolChains/Gnu.cpp
lib/Driver/ToolChains/Gnu.h
lib/Driver/ToolChains/Linux.cpp
lib/Driver/ToolChains/Linux.h
lib/Driver/ToolChains/MSVC.cpp
lib/Driver/ToolChains/MSVC.h
lib/Driver/ToolChains/MinGW.cpp
lib/Driver/ToolChains/MinGW.h
lib/Driver/ToolChains/NetBSD.h
test/Driver/arm-unwind.c
test/Driver/arm-unwind.cpp
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D31140.117139.patch
Type: text/x-patch
Size: 15735 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20170929/3eae96d3/attachment-0001.bin>
More information about the cfe-commits
mailing list