[PATCH] D30295: [analyzer] clarify undef shift result when shift count is negative or exceeds the bit width

Anna Zaks via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Sep 25 12:50:23 PDT 2017


zaks.anna added inline comments.


================
Comment at: lib/StaticAnalyzer/Checkers/UndefResultChecker.cpp:134
+        else if (I->isUnsigned())
+          OS << I->getZExtValue() << ", which is";
+        else
----------------
Please print single quotes around the value.


================
Comment at: lib/StaticAnalyzer/Checkers/UndefResultChecker.cpp:138
+
+        OS << " larger or equal with the width of type '"
+           << B->getLHS()->getType().getAsString() << "'.";
----------------
"equal with the width" -> "equal to the width"


Repository:
  rL LLVM

https://reviews.llvm.org/D30295





More information about the cfe-commits mailing list