[PATCH] D38203: [Sema] Corrected the warn-on-throw-from-noexcept behavior to include nothrow

Aaron Ballman via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Sep 25 05:13:32 PDT 2017


aaron.ballman accepted this revision.
aaron.ballman added a comment.
This revision is now accepted and ready to land.

Aside from a minor testing nit, LGTM! Thanks!



================
Comment at: test/SemaCXX/warn-throw-out-noexcept-func.cpp:20
+  }
+  void __attribute__((nothrow)) SomeThrow() {// expected-note {{function declared non-throwing here}}
+   throw 1; // expected-warning {{has a non-throwing exception specification but}}
----------------
Can you also add a test for `__declspec(nothrow)`?


https://reviews.llvm.org/D38203





More information about the cfe-commits mailing list