[PATCH] D33826: [clang-tidy] avoid pointer cast to more strict alignment check

[Eniko Donatella Toth via Phabricator via cfe-commits]

NorenaLeonetti added a comment.

In https://reviews.llvm.org/D33826#866145, @lebedev.ri wrote:

> In https://reviews.llvm.org/D33826#866133, @NorenaLeonetti wrote:
>
> > In https://reviews.llvm.org/D33826#861226, @aaron.ballman wrote:
> >
> > > Have you run this check over any large code bases to see what the quality of the diagnostics are?
> >
> >
> > `-checks=-*,cert-exp36-c,modernize-unary-static-assert`
> >
> > the result:
> >
> > real    52m6.886s
> >  user    298m8.824s
> >  sys     7m29.292s
> >
> > `-checks=-*,modernize-unary-static-assert`
> >
> > the result:
> >
> > real    52m5.305s
> >  user    302m38.508s
> >  sys     8m53.008s
>
>
> What was meant is, run the check over some large codebase (e.g. all of the LLVM itself), and upload the results somewhere.
>  Then analyze the results. Are there any obvious false-positives?
>  If yes, then minimize the testcase, add it into `test/clang-tidy/cert-avoid-pointer-cast-to-more-strict-alignment.cpp` and fix it's handling.
>  Are there clear bugs in the analyzed code?


I've run the check on the LLVM codebase and got these warnings in the file.
F5385001: test_alignment_check.txt <https://reviews.llvm.org/F5385001>


Repository:
  rL LLVM

https://reviews.llvm.org/D33826