[PATCH] D38048: [clangd] Add textDocument/signatureHelp

[Raoul Wols via Phabricator via cfe-commits]

rwols marked 3 inline comments as done.
rwols added inline comments.


================
Comment at: clangd/ClangdLSPServer.cpp:92
           "completionProvider": {"resolveProvider": false, "triggerCharacters": [".",">",":"]},
+          "signatureHelpProvider": {"triggerCharacters": ["(", ","]},
           "definitionProvider": true
----------------
This required me to adjust the formatting.test file.


================
Comment at: clangd/ClangdUnit.cpp:650
+
+template <class ReturnType, class CodeCompleteConsumerType>
+ReturnType
----------------
Not sure if these template names are according to style.


================
Comment at: test/clangd/signature-help.test:39
+# I'm just putting the questionable result in here now as the expected result.
+# CHECK-DAG: {"label":"bar(float x = 0, int y = 42) -> void","parameters":[{"label":"float x = 0, int y = 42"}]}
+# 
----------------
When there are multiple defaulted parameters after each other, the CK_Optional chunk consists of *all* of those parameters, instead of a CK_Optional chunk per parameter. This might require us to dive into SemaCodeComplete.cpp to fix this. I'm just leaving it as-is right now.


https://reviews.llvm.org/D38048