[PATCH] D38048: [clangd] Add textDocument/signatureHelp

[Raoul Wols via Phabricator via cfe-commits]

rwols updated this revision to Diff 116461.
rwols added a comment.

- Update doxygen comment to say "signature help" instead of "code complete",
- Refactor: put the FillDocumentation member function outside of `CompletionItemsCollector` so that `SignatureHelpCollector` can also use it.
- Refactor: put the FillSortText member function outside of `CompletionItemsCollector` because it has nothing to do with `CompletionItemsCollector`.
- Refactor: Make a templated function called `invokeClangAction` that will invoke the given CodeCompleteConsumer type. Both `clangd::codeComplete` and `clangd::signatureHelp` now call this function.
- Present optional/defaulted parameters too (using `CodeCompletionString::CK_Optional` chunks).


https://reviews.llvm.org/D38048

Files:
  clangd/ClangdLSPServer.cpp
  clangd/ClangdServer.cpp
  clangd/ClangdServer.h
  clangd/ClangdUnit.cpp
  clangd/ClangdUnit.h
  clangd/Protocol.cpp
  clangd/Protocol.h
  clangd/ProtocolHandlers.cpp
  clangd/ProtocolHandlers.h

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D38048.116461.patch
Type: text/x-patch
Size: 26023 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20170925/1c9a309c/attachment-0001.bin>