[PATCH] D38081: Set completion priority of destructors and operators to CCP_Unlikely.

Alex Lorenz via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Sep 22 11:14:53 PDT 2017


arphaman accepted this revision.
arphaman added a comment.
This revision is now accepted and ready to land.

Nice, LGTM

Please keep in mind that LLVM follows a weekly ping rate: https://llvm.org/docs/DeveloperPolicy.html#code-reviews .



================
Comment at: lib/Sema/SemaCodeComplete.cpp:751
+    auto DeclNameKind = ND->getDeclName().getNameKind();
+    if (DeclNameKind == DeclarationName::NameKind::CXXOperatorName ||
+        DeclNameKind == DeclarationName::NameKind::CXXLiteralOperatorName ||
----------------
Nit: `NameKind::` is redundant.


https://reviews.llvm.org/D38081





More information about the cfe-commits mailing list