[PATCH] D38159: [clang] Fix printf fixit for objc specific types

Aaron Ballman via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Sep 22 06:07:17 PDT 2017


aaron.ballman accepted this revision.
aaron.ballman added a comment.
This revision is now accepted and ready to land.

Aside from a few minor nits, LGTM!



================
Comment at: test/FixIt/fixit-format-ios.m:2
+// RUN: cp %s %t
+// RUN: %clang_cc1 -triple thumbv7-apple-ios8.0.0 -fsyntax-only -fblocks -Wformat -fixit %t
+// RUN: grep -v CHECK %t | FileCheck %s
----------------
I don't think you need to enable `-fblocks` for this test.


================
Comment at: test/FixIt/fixit-format-ios.m:12-14
+  // For thumbv7-apple-ios8.0.0 
+  // the underlying type of size_t is unsigned long 
+  // and for ssize_t it is long.
----------------
Reflow these comments.


Repository:
  rL LLVM

https://reviews.llvm.org/D38159





More information about the cfe-commits mailing list