[PATCH] D36150: [clangd] LSP extension to switch between source/header file

[Ilya Biryukov via Phabricator via cfe-commits]

ilya-biryukov accepted this revision.
ilya-biryukov added a comment.

Looks good modulo a few NITS.
Let me know if you need help landing this.



================
Comment at: unittests/clangd/ClangdTests.cpp:910
+  auto FooH = getVirtualTestFilePath("foo.h");
+  auto invalid = getVirtualTestFilePath("main.cpp");
+
----------------
Code style: local variables are `UpperCamelCase`


================
Comment at: unittests/clangd/ClangdTests.cpp:916
+
+  llvm::Optional<Path> pathResult = Server.switchSourceHeader(FooCpp);
+  EXPECT_TRUE(pathResult.hasValue());
----------------
Code style: local variables are `UpperCamelCase`


================
Comment at: unittests/clangd/ClangdTests.cpp:967
+
+  // Test if asking for a corresponding file that doesn't exist returns an empty string.
+  pathResult = Server.switchSourceHeader(invalid);
----------------
The text is over the line limit.
Could you please `clang-format` every submission?


https://reviews.llvm.org/D36150