[PATCH] D38158: [Sema] Null check in BuildDeclarationNameExpr

[Yi Kong via Phabricator via cfe-commits]

kongyi created this revision.
kongyi added a project: clang.

Qualtype may point to null if we cannot infer its type yet.

Fixes PR33843


Repository:
  rL LLVM

https://reviews.llvm.org/D38158

Files:
  lib/Sema/SemaExpr.cpp
  test/SemaCXX/typo-correction-crash.cpp


Index: test/SemaCXX/typo-correction-crash.cpp
===================================================================
--- test/SemaCXX/typo-correction-crash.cpp
+++ test/SemaCXX/typo-correction-crash.cpp
@@ -1,4 +1,4 @@
-// RUN: %clang_cc1 -fsyntax-only -std=c++14 -verify %s
+// RUN: %clang_cc1 -fsyntax-only -std=c++17 -verify %s
 auto check1() {
   return 1;
   return s; // expected-error {{use of undeclared identifier 's'}}
@@ -19,3 +19,5 @@
 FooRecord::NestedNamespace::type x; // expected-error {{no member named 'NestedNamespace' in 'FooRecord'; did you mean 'BarNamespace::NestedNamespace'?}}
 
 void cast_expr(int g) { +int(n)(g); } // expected-error {{undeclared identifier 'n'}}
+
+void bind() { for (const auto& [test,_] : _test_) { }; } // expected-error {{undeclared identifier '_test_'}}
Index: lib/Sema/SemaExpr.cpp
===================================================================
--- lib/Sema/SemaExpr.cpp
+++ lib/Sema/SemaExpr.cpp
@@ -2803,6 +2803,8 @@
 
   {
     QualType type = VD->getType();
+    if (type.isNull())
+      return ExprError();
     if (auto *FPT = type->getAs<FunctionProtoType>()) {
       // C++ [except.spec]p17:
       //   An exception-specification is considered to be needed when:


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D38158.116279.patch
Type: text/x-patch
Size: 1227 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20170921/9e99d6f1/attachment.bin>