[PATCH] D31140: [LLVMbugs] [Bug 18710] Only generate .ARM.exidx and .ARM.extab when needed in EHABI

Christian Bruel via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Sep 21 05:47:18 PDT 2017


chrib added a comment.

Hello,

I didn't find an easy way factorize the change in IsUnwindTableDefault to support the multiple ARM toolchains. After a quick check in Triple::arm in Driver/Toochains, many seem impacted (excepted NetBSD and Darwin that uses DwarfCFI or SJLG).  So here is an attempt to move this into a small arm hook and use.

Also, I realized that the cxx tests was not correctly checked because most of them are invoked as "clang" instead if "clang++" So another proposal is to check the input type in  IsUnwindTablesDefault.

Finally  I've added the clang  tests to check for this.

thanks !


https://reviews.llvm.org/D31140





More information about the cfe-commits mailing list