[PATCH] D38046: [Atomic][X8664] set max atomic inline/promote width according to the target
Wei Mi via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Wed Sep 20 16:08:58 PDT 2017
wmi added inline comments.
================
Comment at: lib/Basic/Targets/X86.h:898
+ MaxAtomicPromoteWidth = 64;
+ MaxAtomicInlineWidth = 64;
+ }
----------------
efriedma wrote:
> wmi wrote:
> > efriedma wrote:
> > > I don't think we need to mess with MaxAtomicPromoteWidth?
> > >
> > > Probably more intuitive to check "if (hasFeature" rather than "if (!hasFeature".
> > >
> > > Adding a dedicated hook for this seems a bit overkill, but I don't have a better suggestion.
> > If 128 bits inline atomic is not supported, what is the point to promote atomic type to 128 bits?
> MaxAtomicPromoteWidth affects the ABI, so it can't vary based on the target CPU.
That make senses. Thanks for the explanation.
Repository:
rL LLVM
https://reviews.llvm.org/D38046
More information about the cfe-commits
mailing list