[PATCH] D36150: [clangd] LSP extension to switch between source/header file

Ilya Biryukov via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Sep 20 00:29:19 PDT 2017


ilya-biryukov added a comment.

In https://reviews.llvm.org/D36150#875623, @Nebiroth wrote:

> In https://reviews.llvm.org/D36150#867971, @ilya-biryukov wrote:
>
> > Overall looks good, but still needs at least a few tests.
>
>
> I have a test for this commit that uses included source and header files, would that be okay to do or should I generate files dynamically? If so, how can I accomplish this?


You are right, unfortunately we don't have a good story for multi-file tests yet.
Let's add a unit-test for the implementation in `ClangdServer`. This can be easily done by using `MockFSProvider`. You may find some examples in `clang-tools-extra/unittest/clangd/ClangdTests.cpp`


https://reviews.llvm.org/D36150





More information about the cfe-commits mailing list