[PATCH] D37954: Try to shorten system header paths when using -MD depfiles

Peter Wu via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Sep 19 18:22:02 PDT 2017


Lekensteyn updated this revision to Diff 115946.
Lekensteyn retitled this revision from "Expand absolute system header paths when using -MD depfiles" to "Try to shorten system header paths when using -MD depfiles".
Lekensteyn edited the summary of this revision.
Lekensteyn added a comment.

Thanks for the feedback, I have the patch accordingly. Changes in v2:

- Add (no-op) -fcanonical-system-headers option as suggested by @thakis (yes, GCC supports this option, but GCC also has a configure option that can change the default which Clang does not have)
- Check whether path is shorter instead of checking for absolute path (matches the original GCC bug, should address @joerg's concern)
- Update tests to use "%t" instead of "%T" (noticed https://reviews.llvm.org/D35396 after looking for whether "mkdir -p" is allowed) + other minor text/redundancy tweaks


https://reviews.llvm.org/D37954

Files:
  include/clang/Driver/Options.td
  include/clang/Frontend/DependencyOutputOptions.h
  lib/Driver/Job.cpp
  lib/Driver/ToolChains/Clang.cpp
  lib/Frontend/CompilerInvocation.cpp
  lib/Frontend/DependencyFile.cpp
  lib/Tooling/ArgumentsAdjusters.cpp
  test/Preprocessor/dependencies-realpath.c

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D37954.115946.patch
Type: text/x-patch
Size: 6995 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20170920/540ed7ea/attachment.bin>


More information about the cfe-commits mailing list