[PATCH] D37629: [Sema] Move some stuff into -Wtautological-unsigned-enum-zero-compare

[Aaron Ballman via Phabricator via cfe-commits]

aaron.ballman added inline comments.


================
Comment at: lib/Sema/SemaChecking.cpp:8593
 
-  bool Match = true;
+  // is this a tautological comparison? if yes, than contains the always-result
+  llvm::Optional<bool> Result;
----------------
Comments should be complete sentences with capitalization and punctuation (here and elsewhere in the patch).

Also, I can't really understand what this comment is saying.


================
Comment at: lib/Sema/SemaChecking.cpp:8596
+  Expr *Value;     // which one is the value, and not a constant?
+  const char *cmp; // the comparison used, as string
 
----------------
Should be `Cmp` per coding standards.


Repository:
  rL LLVM

https://reviews.llvm.org/D37629