[PATCH] D37925: Allow specifying sanitizers in blacklists

[Evgenii Stepanov via Phabricator via cfe-commits]

eugenis added inline comments.


================
Comment at: docs/SanitizerSpecialCaseList.rst:57
+
+Sections are regular expressions written in square brackets that denote which
+sanitizer the following entries apply to. For example, ``[address]`` specifies
----------------
Section names are regular expressions

also, not really a regular expression, more like a wildcard; I don't know what's the right term for this


================
Comment at: lib/CodeGen/CGDeclCXX.cpp:322
+  if (getLangOpts().Sanitize.hasOneOf(ASanMask))
+    if (!isInSanitizerBlacklist(ASanMask, Fn, Loc))
       Fn->addFnAttr(llvm::Attribute::SanitizeAddress);
----------------
vlad.tsyrklevich wrote:
> This use of ASanMask could also confound address & kernel-address as @eugenis pointed out.
It would be more readable to split it in two if-s, IMHO: one for asan, one for kernel-asan.



https://reviews.llvm.org/D37925