[PATCH] D37972: [clangd] Introduced Logger interface.

[Ilya Biryukov via Phabricator via cfe-commits]

ilya-biryukov added inline comments.


================
Comment at: clangd/GlobalCompilationDatabase.cpp:88
       if (!Error.empty()) {
-        // FIXME(ibiryukov): logging
-        // Output.log("Error when trying to load compilation database from " +
-        //            Twine(Path) + ": " + Twine(Error) + "\n");
+        Logger.log("Error when trying to load compilation database from " +
+                   Path + ": " + Twine(Error) + "\n");
----------------
malaperle wrote:
> Will this log for every parent folder that doesn't contain the compilation database? I haven't tried to confirm. Just wondering because it could get very spammy.
You're totally right, it's incredibly spammy. I've removed logging from this line.
Thanks for the finding!


https://reviews.llvm.org/D37972