[PATCH] D36431: Add powerpc64 to compiler-rt build infrastructure.

Nemanja Ivanovic via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Sep 18 05:54:20 PDT 2017


nemanjai accepted this revision.
nemanjai added subscribers: hfinkel, echristo.
nemanjai added a comment.
This revision is now accepted and ready to land.

I hope I haven't lost track of the patches that precluded this. If I remember correctly, all the X86 80-bit stuff was sorted out. We now know why those test cases were running forever (i.e. a vaarg function invoked as a non-vaarg function). So this just enables the truly generic builtins along with some PPC builtins. If my understanding is correct, I'd say this is ready to proceed (unless it was subsumed by one of the other patches).

Long story short... LGTM.
You may want to get the green light from @hfinkel or @echristo and/or one of the compiler-rt experts as well.


https://reviews.llvm.org/D36431





More information about the cfe-commits mailing list