[PATCH] D37941: [X86] Move even more of our CPU to feature mapping switch to use fallthroughs

Simon Pilgrim via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Sat Sep 16 02:32:05 PDT 2017


RKSimon accepted this revision.
RKSimon added a comment.
This revision is now accepted and ready to land.

LGTM, there are a couple of other fall-throughs that could still be done.



================
Comment at: lib/Basic/Targets/X86.cpp:141
     setFeatureEnabledImpl(Features, "sse2", true);
     setFeatureEnabledImpl(Features, "fxsr", true);
     break;
----------------
CK_Pentium3/CK_C3_2/CK_PentiumM/CK_Pentium4/CK_x86_64 can be put below Yonah et al. (unless you're worried about including non-Intel enums)?


https://reviews.llvm.org/D37941





More information about the cfe-commits mailing list