[PATCH] D37891: Driver: hoist the `wchar_t` handling to the driver

Saleem Abdulrasool via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Sep 15 09:33:22 PDT 2017


compnerd added a comment.

We could leave the defaults there as they stand, and only have the new flags alter the default.  However, it seems that just paying the cost of adjusting the tests once isn't too bad.  To me, it seems that having one instance of the horrible logic for determining the type of `wchar_t` is better than having two copies which can diverge slightly.  My understanding was that we determined that it was better to just pay this test adjustment cost, since it would treat all the targets the same.


Repository:
  rL LLVM

https://reviews.llvm.org/D37891





More information about the cfe-commits mailing list