[PATCH] D37322: [Sema] Correct typos in LHS, RHS before building a binop expression.

Akira Hatanaka via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Sep 14 14:06:55 PDT 2017


ahatanak accepted this revision.
ahatanak added a comment.
This revision is now accepted and ready to land.

I see. It looks like there is an ambiguity between 'new_anotation' and 'new_annotations' that can't be resolved in ActOnMemberAccessExpr because they have the same distance from 'new_annotation'. This doesn't happen if the full expression (new_annotation->Swap) is typo-corrected because 'new_anotation' will be the only valid choice in that case.

I don't think there is a problem with creating CXXDependentScopeMemberExpr for ObjC property access, so this looks fine.


https://reviews.llvm.org/D37322





More information about the cfe-commits mailing list