[PATCH] D35796: [analyzer] Misused polymorphic object checker

Reka Kovacs via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Sep 14 04:54:52 PDT 2017


rnkovacs marked 3 inline comments as done.
rnkovacs added inline comments.


================
Comment at: include/clang/StaticAnalyzer/Checkers/Checkers.td:296
 
+def MisusedPolymorphicObjectChecker: Checker<"MisusedPolymorphicObject">,
+     HelpText<"Reports deletions of polymorphic objects with a non-virtual "
----------------
dcoughlin wrote:
> I think users would find it helpful if this had a more specific name. There are a lot of ways to misuse polymorphic objects, and this checker won't check all of them.
> 
> What do you think about "DeleteWithNonVirtualDestructor"?
I settled with the slightly abbreviated "DeleteWithNonVirtualDtor" version to shorten it a little.


https://reviews.llvm.org/D35796





More information about the cfe-commits mailing list