[PATCH] D37035: Implement __builtin_LINE() et. al. to support source location capture.

[Eric Fiselier via Phabricator via cfe-commits]

EricWF added inline comments.


================
Comment at: lib/AST/Expr.cpp:1940
            false, false),
-    InitExprs(C, initExprs.size()),
-    LBraceLoc(lbraceloc), RBraceLoc(rbraceloc), AltForm(nullptr, true)
-{
+      InitExprs(C, initExprs.size()), LBraceLoc(lbraceloc),
+      RBraceLoc(rbraceloc), AltForm(nullptr, true) {
----------------
Urg... Not sure how both clang-format and git -w messed up enough to let these whitespace changes through (and the ones below this).


================
Comment at: lib/AST/ExprConstant.cpp:591
 
+    SourceLocContextRAIIBase *EvaluatingDefaultArg;
+    SourceLocContextRAIIBase *EvaluatingDefaultMemberInit;
----------------
These members need documentation.


================
Comment at: lib/AST/ExprConstant.cpp:6279
 
+    const auto *DIE = dyn_cast<CXXDefaultInitExpr>(InitExpr);
     // Temporarily override This, in case there's a CXXDefaultInitExpr in here.
----------------
This change seems unnecessary. 


https://reviews.llvm.org/D37035