[PATCH] D37089: [Sema] Error out early for tags defined inside an enumeration.

Reid Kleckner via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Sep 13 16:46:53 PDT 2017


rnk added a comment.

I think this looks good, even without fixing the access control crash, this seems like a diagnostic improvement.



================
Comment at: clang/test/Sema/enum.c:128
+// PR28903
+struct PR28903 { // expected-warning {{empty struct is a GNU extension}}
+  enum {
----------------
This is a simpler test case that fixes the extraneous diagnostics:
  struct PR28903 {
    enum {
      E1 = (enum {  // expected-error-re {{...}}
              E2, E3 = E2
            })0
    } e;
  };



https://reviews.llvm.org/D37089





More information about the cfe-commits mailing list