[PATCH] D37042: Teach clang to tolerate the 'p = nullptr + n' idiom used by glibc

Andy Kaylor via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Sep 13 14:42:22 PDT 2017


andrew.w.kaylor added inline comments.


================
Comment at: include/clang/Basic/DiagnosticSemaKinds.td:6031
   InGroup<PointerArith>;
+def ext_gnu_null_ptr_arith : Extension<
+  "arithmetic on a null pointer treated as a cast from integer to pointer is a GNU extension">,
----------------
efriedma wrote:
> "extension" isn't really right here; this shouldn't be an error in -pedantic-errors mode.  Probably best to just stick this into the NullPointerArithmetic, like the other new warning.
So how should a word the warning?  Just this:

"arithmetic on a null pointer treated as a cast from integer to pointer"?


https://reviews.llvm.org/D37042





More information about the cfe-commits mailing list