[PATCH] D28212: typeinfo: provide a partial implementation for Win32

[Shoaib Meenai via Phabricator via cfe-commits]

smeenai added a comment.

Rebased and tested on Windows again.

I'd like to see this patch get through to reduce the dependencies on the `vcruntime` headers, since those end up pulling in lots of cruft and can cause some nasty conflicts. (Similarly, I'll be trying to remove dependencies on `Windows.h`, which is an evil, evil header.)

There's a behavior difference between this implementation and vcruntime's, since this one doesn't demangle the type name. Idk how much that difference matters in practice though, and I think it's fine to address in a follow-up.

What else needs to be addressed before this is good to go?



================
Comment at: include/typeinfo:109
 protected:
+#if defined(_LIBCPP_HAS_MS_ABI_TYPEINFO)
+#else
----------------
compnerd wrote:
> EricWF wrote:
> > Don't we need a constructor here?
> No, we do not need a constructor since the emitted object is already a well formed object instance.
I believe @EricWF was referring to the internal constructors that take a `const char *`. Do we need one of those for the Microsoft typeinfo?


https://reviews.llvm.org/D28212