[PATCH] D37598: [ubsan] Enable -fsanitize=function on Darwin

[Phabricator via Phabricator via cfe-commits]

This revision was automatically updated to reflect the committed changes.
Closed by commit rL313097: [ubsan] Enable -fsanitize=function test on Darwin (authored by vedantk).

Changed prior to commit:
  https://reviews.llvm.org/D37598?vs=114268&id=114944#toc

Repository:
  rL LLVM

https://reviews.llvm.org/D37598

Files:
  compiler-rt/trunk/test/ubsan/TestCases/TypeCheck/Function/function.cpp


Index: compiler-rt/trunk/test/ubsan/TestCases/TypeCheck/Function/function.cpp
===================================================================
--- compiler-rt/trunk/test/ubsan/TestCases/TypeCheck/Function/function.cpp
+++ compiler-rt/trunk/test/ubsan/TestCases/TypeCheck/Function/function.cpp
@@ -3,9 +3,6 @@
 // Verify that we can disable symbolization if needed:
 // RUN: %env_ubsan_opts=symbolize=0 %run %t 2>&1 | FileCheck %s --check-prefix=NOSYM
 
-// -fsanitize=function is unsupported on Darwin yet.
-// XFAIL: darwin
-
 #include <stdint.h>
 
 void f() {}
@@ -18,9 +15,9 @@
 }
 
 void make_invalid_call() {
-  // CHECK: function.cpp:25:3: runtime error: call to function f() through pointer to incorrect function type 'void (*)(int)'
-  // CHECK-NEXT: function.cpp:11: note: f() defined here
-  // NOSYM: function.cpp:25:3: runtime error: call to function (unknown) through pointer to incorrect function type 'void (*)(int)'
+  // CHECK: function.cpp:[[@LINE+4]]:3: runtime error: call to function f() through pointer to incorrect function type 'void (*)(int)'
+  // CHECK-NEXT: function.cpp:[[@LINE-11]]: note: f() defined here
+  // NOSYM: function.cpp:[[@LINE+2]]:3: runtime error: call to function (unknown) through pointer to incorrect function type 'void (*)(int)'
   // NOSYM-NEXT: ({{.*}}+0x{{.*}}): note: (unknown) defined here
   reinterpret_cast<void (*)(int)>(reinterpret_cast<uintptr_t>(f))(42);
 }


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D37598.114944.patch
Type: text/x-patch
Size: 1422 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20170913/411e5f0e/attachment.bin>