[PATCH] D37322: [Sema] Correct typos in LHS, RHS before building a binop expression.

[Akira Hatanaka via Phabricator via cfe-commits]

ahatanak added a comment.

I was thinking about correcting the typo in Sema::ActOnMemberAccessExpr before checking whether Base is dependent. Doing so would cause BuildMemberReferenceExpr to be called instead of ActOnDependentMemberExpr.

I thought that would be a simpler approach, but I'm actually not sure which approach is better. I think this patch should be fine too as long as creating CXXDependentScopeMemberExpr for an ObjC property access doesn't cause a problem before typo correction.

What do you think?


https://reviews.llvm.org/D37322