[PATCH] D36720: [libc++] Prevent stale site configuration headers

[Eric Fiselier via Phabricator via cfe-commits]

EricWF accepted this revision.
EricWF added inline comments.
This revision is now accepted and ready to land.


================
Comment at: CMakeLists.txt:633
+  if (EXISTS "${site_config_path}")
+    file(REMOVE "${site_config_path}")
+  endif()
----------------
Maybe print a warning or a message here? While it seems useful to re-configure and remove the stale header without requiring the user delete the build directory, it does seem like an odd thing to do, at least silently.

Since this shouldn't be happening very often, I don't think it would be too noisy to explicitly warn the user what is going on.



https://reviews.llvm.org/D36720