[PATCH] D37134: [libc++] Rerun ranlib manually after merging the static libraries

Martin Storsjö via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Sep 12 13:32:13 PDT 2017


mstorsjo added a comment.

In https://reviews.llvm.org/D37134#868497, @EricWF wrote:

> Ironically I think parts of this change should be moved into `merge_archives.py`.
>
> > the ar used in merge_archives.py might not be the right one for the target
>
> OK, then we should modify `merge_archives.py` to support optionally specifying the `ar` executable.
>
> >   (and the invocation doesn't include the 's' modifier for updating the archive index)
>
> Isn't this also just a bug in `merge_archives.py`?


Hm, indeed, that's probably a better solution. I'll give that a go and see how it goes.


https://reviews.llvm.org/D37134





More information about the cfe-commits mailing list