[PATCH] D37668: [X86][intrinsics] lower _mm[256|512]_mask[z]_set1_epi[8|16|32|64] intrinsic to IR

[Simon Pilgrim via Phabricator via cfe-commits]

RKSimon added a comment.

some very minor whitespace/indentation issues

please can you confirm  @craig.topper's query about __builtin_ia32_pbroadcastq512_mem_mask



================
Comment at: lib/Headers/avx512vlintrin.h:5727
+static __inline__ __m128i __DEFAULT_FN_ATTRS
+ _mm_mask_set1_epi32(__m128i __O, __mmask8 __M, int __A) {
+   return (__m128i)__builtin_ia32_selectd_128(__M,
----------------
weird indentation?


================
Comment at: lib/Headers/avx512vlintrin.h:5734
+static __inline__ __m128i __DEFAULT_FN_ATTRS
+ _mm_maskz_set1_epi32( __mmask8 __M, int __A) {
+   return (__m128i)__builtin_ia32_selectd_128(__M,
----------------
weird indentation?


================
Comment at: lib/Headers/avx512vlintrin.h:5741
+static __inline__ __m256i __DEFAULT_FN_ATTRS
+ _mm256_mask_set1_epi32(__m256i __O, __mmask8 __M, int __A) {
+   return (__m256i)__builtin_ia32_selectd_256(__M,
----------------
weird indentation?


================
Comment at: lib/Headers/avx512vlintrin.h:5748
+static __inline__ __m256i __DEFAULT_FN_ATTRS
+ _mm256_maskz_set1_epi32( __mmask8 __M, int __A) {
+   return (__m256i)__builtin_ia32_selectd_256(__M,
----------------
weird indentation?


================
Comment at: test/CodeGen/avx512f-builtins.c:7732
+   // CHECK-LABEL: @test_mm512_mask_set1_epi32
+    // CHECK: insertelement <16 x i32> undef, i32 %{{.*}}, i32 0
+  // CHECK: insertelement <16 x i32> %{{.*}}, i32 %{{.*}}, i32 1
----------------
weird indentation?


================
Comment at: test/CodeGen/avx512f-builtins.c:7755
+  // CHECK-LABEL: @test_mm512_maskz_set1_epi32
+    // CHECK: insertelement <16 x i32> undef, i32 %{{.*}}, i32 0
+  // CHECK: insertelement <16 x i32> %{{.*}}, i32 %{{.*}}, i32 1
----------------
weird indentation?


================
Comment at: test/CodeGen/avx512f-builtins.c:7966
     //CHECK: insertelement{{.*}}i32 14
     //CHECK: insertelement{{.*}}i32 15
  return _mm512_setr_epi32( __A, __B, __C, __D,__E, __F, __G, __H,
----------------
weird indentation?


================
Comment at: test/CodeGen/avx512vl-builtins.c:4597
   // CHECK-LABEL: @test_mm256_maskz_set1_epi64
-  // CHECK: @llvm.x86.avx512.mask.pbroadcast.q.gpr.256
+    // CHECK: insertelement <4 x i64> undef, i64 %{{.*}}, i32 0
+  // CHECK: insertelement <4 x i64> %{{.*}}, i64 %{{.*}}, i32 1
----------------
weird indentation?


https://reviews.llvm.org/D37668