[PATCH] D34695: _Float16 preprocessor macro definitions

Steve Canon via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Sep 12 08:36:57 PDT 2017


scanon added inline comments.


================
Comment at: lib/Headers/float.h:137
 
+#ifdef __STDC_WANT_IEC_60559_TYPES_EXT__
+#  define FLT16_MANT_DIG  __FLT16_MANT_DIG__
----------------
rogfer01 wrote:
> My understanding is that, given that we support TS18661-2 by default, this macro should be predefined by clang and then there is no need to protect these macros.
> 
> You may want to add a test for this in `test/Preprocessor/init.c`.
Where do you see that the `__STDC_WANT_IEC_60559_TYPES_EXT__` macro should be predefined by clang?


https://reviews.llvm.org/D34695





More information about the cfe-commits mailing list