[PATCH] D37727: Driver: Remove custom MinGW linker detection

[Martin Storsjö via Phabricator via cfe-commits]

mstorsjo added a comment.

I'm not sure I like this direction. In my setups, a build-time default isn't right since I'm using the same clang builds for both native-on-linux building (with the default `ld` as linker) and cross-building targeting windows (using `ldd`), and keeping the code that reads `-fuse-ld=` is essential.

I haven't followed the changes closely on how this works with the build-time `CLANG_DEFAULT_LINKER`, but can't we just make the current code check this define if `-fuse-ld` isn't set?



================
Comment at: lib/Driver/ToolChains/MinGW.cpp:107
 
-  StringRef LinkerName = Args.getLastArgValue(options::OPT_fuse_ld_EQ, "lld");
-  if (LinkerName.equals_lower("lld")) {
----------------
This diff isn't based on the current master version, where this defaults to `ld`


================
Comment at: lib/Driver/ToolChains/MinGW.cpp:236
         CmdArgs.push_back("--end-group");
-      else if (!LinkerName.equals_lower("lld"))
+      else
         AddLibGCC(Args, CmdArgs);
----------------
So if you do a clang build that defaults to `lld`, this should suddenly be included?


Repository:
  rL LLVM

https://reviews.llvm.org/D37727