[PATCH] D37529: [codeview] omit debug locations for nested exprs unless column info enabled

Reid Kleckner via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Sep 11 14:03:19 PDT 2017


rnk added inline comments.


================
Comment at: clang/lib/CodeGen/CodeGenModule.h:32
 #include "clang/Basic/XRayLists.h"
+#include "clang/Frontend/CodeGenOptions.h"
 #include "llvm/ADT/DenseMap.h"
----------------
majnemer wrote:
> Any reason to do this? I'd just keep getNestedExpressionLocationsEnabled in the .cpp file.
+1, I think we can continue to expect that ApplyDebugLocation will be used for expression emission and CodeGenFunction::EmitStopPoint (or whatever we rename it to) will be called for statements in CGStmt.


https://reviews.llvm.org/D37529





More information about the cfe-commits mailing list