[PATCH] D37577: [libclang] add 'clang_getCursorTLSKind'

Saleem Abdulrasool via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Sep 11 09:01:57 PDT 2017


compnerd added inline comments.


================
Comment at: bindings/python/tests/cindex/test_tls_kind.py:14
+int tls_none;
+thread_local tls_dynamic;
+""", lang = 'cpp')
----------------
Can we add a test case for static TLS as well please?  Also, I think that we should add a test case for `__declspec(thread)`.


================
Comment at: tools/libclang/CIndex.cpp:7426
+    }
+  }
+
----------------
This block is not properly formatted.  Please clang-format your code.


https://reviews.llvm.org/D37577





More information about the cfe-commits mailing list