[libcxxabi] r308470 - Drop 'svn' suffix from version number.

[Shoaib Meenai via cfe-commits]

Note that Reid restored the old behavior in r312043.

Configuring with -DLLVM_APPEND_VC_REV=OFF should also restore the old
behavior, I believe.

On 9/9/17, 1:55 PM, "cfe-commits on behalf of Dimitry Andric via cfe-commits" <cfe-commits-bounces at lists.llvm.org on behalf of cfe-commits at lists.llvm.org> wrote:

    On 19 Jul 2017, at 16:04, Hans Wennborg via cfe-commits <cfe-commits at lists.llvm.org> wrote:
    > 
    > Author: hans
    > Date: Wed Jul 19 07:04:19 2017
    > New Revision: 308470
    > 
    > URL: http://llvm.org/viewvc/llvm-project?rev=308470&view=rev
    > Log:
    > Drop 'svn' suffix from version number.
    
    [Replying to this commit, since I don't have r308469 (which does the same for llvm itself) in my mailboxes.]
    
    Note this approach isn't effective anymore after Rafael's
    https://reviews.llvm.org/rL306858, which turns on the LLVM_APPEND_VC_REV
    option by default.
    
    The handling of that option will overwrite the PACKAGE_VERSION value set
    earlier in CMakeLists.txt, with the value returned from
    add_version_info_from_vcs().  When using Subversion, that will always be
    of the form X.Y.Zsvn-rNNNNNN.
    
    I noticed this when preparing the 5.0.0 final import into FreeBSD, where
    for example "opt -version" outputs:
    
    LLVM (http://llvm.org/):
      LLVM version 5.0.0svn-r312559
      Optimized build with assertions.
      Default target: x86_64-unknown-freebsd12.0
      Host CPU: ivybridge
    
    -Dimitry