[PATCH] D34784: [OpenMP] Add flag for specifying the target device architecture for OpenMP device offloading

[Francis Ricci via Phabricator via cfe-commits]

fjricci added inline comments.


================
Comment at: lib/Driver/ToolChain.cpp:851
+      XOpenMPTargetArg->setBaseArg(A);
+      A = XOpenMPTargetArg.release();
+      DAL->append(A);
----------------
Hahnfeld wrote:
> This is a memory leak that is currently triggered in `tests/Driver/openmp-offload-gpu.c` and found by ASan. How to fix this? I'm not really familiar with OptTable...
Even with the follow-up patch to fix the memory leak, I'm still seeing this pointer leaked (on Darwin with ASan and detect_leaks=1). I've tried playing around with a few fixes myself, but haven't been able to get anything working.


https://reviews.llvm.org/D34784