[PATCH] D35082: [OpenCL] Add LangAS::opencl_private to represent private address space in AST

[Anastasia Stulova via Phabricator via cfe-commits]

Anastasia added inline comments.


================
Comment at: lib/Sema/SemaType.cpp:6994
+      // OpenCL v1.2 s6.5:
+      // The generic address space name for arguments to a function in a
+      // program, or local variables of a function is __private. All function
----------------
yaxunl wrote:
> Anastasia wrote:
> > yaxunl wrote:
> > > Anastasia wrote:
> > > > The generic address space -> The default address space
> > > 'The generic address space name for arguments' is literally from the OpenCL 1.2 spec. Note it refers 'generic address space name', which is not the 'generic address space' defined by OpenCL 2.0 spec.
> > True, but this spec was written before v2.0 was released. And I feel now it makes things confusing considering that we have v2.0 implementation too.
> I can make the change. I just feel a little bit uneasy since this looks like a citation but actually is rephrased.
Cool! Thanks!


https://reviews.llvm.org/D35082