[PATCH] D37565: [Sema] -Wtautological-compare: handle comparison of unsigned with 0S.

John McCall via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Sep 7 15:08:37 PDT 2017


rjmccall accepted this revision.
rjmccall added a comment.
This revision is now accepted and ready to land.

LGTM.



================
Comment at: docs/ReleaseNotes.rst:79
+- ``-Wtautological-compare`` now warns about comparison of signed integer and
+  ``0U`` constant when appropriate.
+
----------------
rjmccall wrote:
> Probably better to be clear here: "now warns about comparing a signed integer and 0 when the signed integer is coerced to an unsigned type for the comparison."
That's great, thanks.


Repository:
  rL LLVM

https://reviews.llvm.org/D37565





More information about the cfe-commits mailing list