[PATCH] D35533: [Basic] Update CMakeLists.txt to handle Repo with git
Don Hinton via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Wed Sep 6 17:50:28 PDT 2017
hintonda added a comment.
In https://reviews.llvm.org/D35533#862852, @minseong.kim wrote:
> @hintonda, Absolutely. Incorporating @modocache's module changes into the version in AddLLVM.cmake would solve the current version display issue for repo and do not affect the process of other version control systems (e.g. git, git-svn, svn, and git submodule).
I think we crossed, but yes, the version in AddLLVM.cmake handles everything correctly. So, I'd recommend removing these versions.
https://reviews.llvm.org/D35533
More information about the cfe-commits
mailing list