[PATCH] D37529: [codeview] omit debug locations for nested exprs unless column info enabled

[Zachary Turner via Phabricator via cfe-commits]

zturner added inline comments.


================
Comment at: clang/lib/CodeGen/CGDebugInfo.h:65
   llvm::MDNode *CurInlinedAt = nullptr;
+  bool LocationEnabled = true;
   llvm::DIType *VTablePtrType = nullptr;
----------------
Can you move this line up to put it next to another bool?  Not a huge deal, but might as well pack the class members.


================
Comment at: clang/test/CodeGenCXX/debug-info-nested-exprs.cpp:44
+  int a = bar(x, y) +
+          baz(x, z) +
+          qux(y, z);
----------------
Can you make a function called `int foo()` and make this `int a = bar(foo(), y) + ...`


https://reviews.llvm.org/D37529