[PATCH] D37529: [codeview] omit debug locations for nested exprs unless column info enabled

[Reid Kleckner via Phabricator via cfe-commits]

rnk added inline comments.


================
Comment at: clang/test/CodeGenCXX/debug-info-nested-exprs.cpp:12
+
+// NONEST: call i32 @{{.*}}bar{{.*}}, !dbg ![[LOC:[0-9]+]]
+// NONEST: call i32 @{{.*}}baz{{.*}}, !dbg ![[LOC]]
----------------
inglorion wrote:
> rnk wrote:
> > This is pretty painful to test. :(
> > 
> > If we let ourselves do an asm test, .cv_loc is printed with some nice assembly comments that make this testing easy.
> Would you like me to write an asm test in addition to / instead of this one?
Oops, I thought I wrote this comment and deleted it before hitting send, but apparently not. No, let's stick with the IR test.


https://reviews.llvm.org/D37529