[PATCH] D37381: Fix regression in special member definitions under SuppressAllDiagnostics

[Brad King via Phabricator via cfe-commits]

brad.king abandoned this revision.
brad.king added a comment.

@rsmith thanks.

> If a node is not marked invalid, that does not imply the corresponding source code is valid.

Okay, that clears up my understanding.

> hook into the start and end of creating a function (so you can install your own error trap from an external user of Sema)

I only need a way to detect special members in C++98 that won't compile (since they won't be `isDeleted`), not trap bad code in general.  I found that I can install my own error trap around my code that forces the definition of each special member.

Therefore we can abandon this change.  Thanks!


https://reviews.llvm.org/D37381