[PATCH] D37101: [clangd] Add support for snippet completions

[Raoul Wols via Phabricator via cfe-commits]

rwols updated this revision to Diff 113899.
rwols added a comment.

- Don't use const for non-reference parameters
- `lowerCamelCase` for functions, verb phrase
- Field definitions at the bottom of the class
- Make ProcessChunks virtual
- Add comment that fallthrough to the next case is intended
- Revert new constructors for CompletionItem, they are pointless
- Bump minimum version for vscode-languageclient and vscode-languageserver to 3.3.0


https://reviews.llvm.org/D37101

Files:
  clangd/ClangdLSPServer.cpp
  clangd/ClangdLSPServer.h
  clangd/ClangdServer.cpp
  clangd/ClangdServer.h
  clangd/ClangdUnit.cpp
  clangd/ClangdUnit.h
  clangd/Protocol.cpp
  clangd/clients/clangd-vscode/package.json
  clangd/tool/ClangdMain.cpp
  test/clangd/authority-less-uri.test
  test/clangd/completion-snippet.test
  test/clangd/completion.test

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D37101.113899.patch
Type: text/x-patch
Size: 30274 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20170905/b0b53075/attachment-0001.bin>