[PATCH] D37386: [AMDGPU] Implement infrastructure to set options in AMDGPUToolChain

[Andrey Kasaurov via Phabricator via cfe-commits]

kasaurov updated this revision to Diff 113767.
kasaurov added a comment.

Several requested changes:

- move map initialization out of header file -- visually it looks better in .h file, but logically it should be in .cpp
- add assert() in getOptionDefault() -- check for unknown to OptionsDefault option
- combine args for OPT_O check
- use const StrinRef instead of std::string in the map and getOptionDefault() -- that eliminates conversion in AddJoinedArg()
- eliminate redundant brackets

ToDo:

- test


https://reviews.llvm.org/D37386

Files:
  lib/Driver/ToolChains/AMDGPU.cpp
  lib/Driver/ToolChains/AMDGPU.h

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D37386.113767.patch
Type: text/x-patch
Size: 3557 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20170904/6e96fd88/attachment.bin>