[PATCH] D37282: clangd: Tolerate additional headers

Ilya Biryukov via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Sep 4 03:33:25 PDT 2017


ilya-biryukov added inline comments.


================
Comment at: clangd/JSONRPCDispatcher.cpp:167
+      // It's another header, ignore it.
       continue;
+    } else {
----------------
puremourning wrote:
> ilya-biryukov wrote:
> > Maybe log the skipped header?
> I think this would just be noise for conforming clients which send the (legitimate) Content-Type header. We could of course special case this, but I'm not sure the extra logging would be all that useful.
You're right. Logging `Content-Type` headers doesn't make any sense.


https://reviews.llvm.org/D37282





More information about the cfe-commits mailing list