[PATCH] D37390: [diagtool] Change default tree behavior to print only flags

Jonas Devlieghere via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Sep 4 02:28:14 PDT 2017


JDevlieghere updated this revision to Diff 113731.
JDevlieghere added a comment.
Herald added subscribers: aheejin, klimek.

Thanks for the review Adrian!

I somehow completely overlooked the existing `--flags-only` option in `diagtool tree`. Obviously it makes much more sense to implement printing flags here and make it the default behavior. I've also added some code to print the flags with the appropriate color, i.e. defaults are printed in green while the others remain printed in yellow as before.

I've updated the diff to reflect this and added a test case.


Repository:
  rL LLVM

https://reviews.llvm.org/D37390

Files:
  test/Tooling/diatool.test
  tools/diagtool/TreeView.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D37390.113731.patch
Type: text/x-patch
Size: 30340 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20170904/8a01c5ee/attachment-0001.bin>


More information about the cfe-commits mailing list