[PATCH] D37383: [AST] Add TableGen for StmtDataCollectors

Alex Lorenz via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Sep 4 00:44:31 PDT 2017


arphaman accepted this revision.
arphaman added a comment.

`def`s could work, but I think that we should stick with TableGen. As you've said, we'd be able to introduce some sort of structure instead of just code in the future which will be better (Ideally we'd try to do it now, but given the fact that the GSoC is done the current approach is acceptable). I would also like to see this analyzed and tested better in the future to ensure a complete coverage of AST, and I think the use of TableGen can potentially help with that.


https://reviews.llvm.org/D37383





More information about the cfe-commits mailing list