r312407 - Don't search libxml2 if using msan. LLVM already has similar check.

Vitaly Buka via cfe-commits cfe-commits at lists.llvm.org
Fri Sep 1 20:53:42 PDT 2017


Author: vitalybuka
Date: Fri Sep  1 20:53:42 2017
New Revision: 312407

URL: http://llvm.org/viewvc/llvm-project?rev=312407&view=rev
Log:
Don't search libxml2 if using msan. LLVM already has similar check.

Modified:
    cfe/trunk/CMakeLists.txt

Modified: cfe/trunk/CMakeLists.txt
URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/CMakeLists.txt?rev=312407&r1=312406&r2=312407&view=diff
==============================================================================
--- cfe/trunk/CMakeLists.txt (original)
+++ cfe/trunk/CMakeLists.txt Fri Sep  1 20:53:42 2017
@@ -181,10 +181,14 @@ endif()
 # we can include cmake files from this directory.
 list(APPEND CMAKE_MODULE_PATH "${CMAKE_CURRENT_SOURCE_DIR}/cmake/modules")
 
-set (LIBXML2_FOUND 0)
-find_package(LibXml2 2.5.3 QUIET)
-if (LIBXML2_FOUND)
-  set(CLANG_HAVE_LIBXML 1)
+# Don't look for libxml if we're using MSan, since uninstrumented third party
+# code may call MSan interceptors like strlen, leading to false positives.
+if(NOT LLVM_USE_SANITIZER MATCHES "Memory.*")
+  set (LIBXML2_FOUND 0)
+  find_package(LibXml2 2.5.3 QUIET)
+  if (LIBXML2_FOUND)
+    set(CLANG_HAVE_LIBXML 1)
+  endif()
 endif()
 
 include(CheckIncludeFile)




More information about the cfe-commits mailing list